Run Remix on Deno #2243

pcattori · 2022-03-07T15:49:45Z

I removed remix-deno package (see commit message for details). Idea is to take the remix-deno package currently inlined in our new Deno template (see https://github.com/pcattori/remix-deno-template for a prototype of that) and make that importable in Deno. Note that this would mean treating remix-deno as a Deno package, not a node package.

I don't think this should be considered a breaking change since (1) Deno support is experimental (2) previous Deno template was immediately erroring out.

Closes: #

Docs
Tests

remix-cla-bot · 2022-03-07T15:49:48Z

Hi @pcattori,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

remix-cla-bot · 2022-03-07T16:31:17Z

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

pcattori · 2022-03-14T23:27:34Z

templates/deno/package.json

+      "dev:deno": "cross-env NODE_ENV=development deno run --watch --allow-net --allow-read --allow-env ./build/index.js"
+    },
+    "devDependencies": {
+      "@remix-run/dev": "^1.2.2",


TODO: We need to update this to be the version for the release of @remix-run/dev that includes these changes. @chaance do we know if this will be 1.2.4 or 1.3.0?

I guess we can say ^1.2.4 and it will work even if we go straight from 1.2.3 to 1.30. Feels a little weird to reference a non-existing version but 🤷 it would work.

I think this should be * for now. The install script finds all remix deps in package.json and updates them with the right version when it uses the template.

@mcansh changed this to actual values in #2189

react is always imported explicilty in deno when authoring react-based jsx (need to double check this)

Current remix-deno package is being treated like a node package (eslint, jest, tsc, rollup, etc..). It should instead be a Deno package (i.e. Deno source code, Deno tooling, etc..). Right now we inline a proper `remix-deno` package in our Deno template, so this remix-deno package is incorrect and outdated.

pcattori · 2022-03-14T23:38:36Z

packages/remix-dev/tsconfig.json

@@ -13,6 +13,7 @@

    "declaration": true,
    "emitDeclarationOnly": true,
+    "skipLibCheck": true,


@jacob-ebey : what was the reason for enabling skipLibCheck? Is it because esbuild-plugin-cache pulls in deno-cache and deno-importmap as dependencies and type checking fails for those?

If so, might be better to create a declaration file for whatever dependencies are causing this issue so that we don't stop type checking our usage of other dependencies with good types.

mjackson

Looking good, @pcattori! Almost there.

mjackson · 2022-03-15T00:04:18Z

templates/deno/package.json

+      "dev:deno": "cross-env NODE_ENV=development deno run --watch --allow-net --allow-read --allow-env ./build/index.js"
+    },
+    "devDependencies": {
+      "@remix-run/dev": "^1.2.2",


I think this should be * for now. The install script finds all remix deps in package.json and updates them with the right version when it uses the template.

templates/deno/app/routes/index.tsx

templates/deno/app/entry.server.tsx

templates/deno/app/root.tsx

temporary scaffoling and known issues described in templates/deno/README.md

Signed-off-by: Logan McAnsh <logan@mcan.sh>

currently referencing the dev branch, but should reference main branch for release

F3n67u · 2022-03-22T01:54:07Z

templates/deno-ts/deno.json

@@ -0,0 +1,6 @@
+{
+  "compilerOptions": {
+    "lib": ["dom", "dom.iterable", "dom.asynciterable", "deno.ns"]


Hi @pcattori could you elaborate on why we should customize lib? this line caused the error reported in #2402

I copied it from some of the prior work we had done on Deno, but it might be a vestige from when we were trying to use standard Node tooling + Typescript compiler to produce a Deno bundle. We've since abandoned that approach in favor of writing Deno source code (eventually with Deno tooling like deno fmt, deno lint, etc... in CI).

Could very well be the case that we should remove the lib option.

Let's continue the discussion in #2402

pcattori force-pushed the pedro/deno branch 3 times, most recently from 692970c to 0e37509 Compare March 7, 2022 16:31

remix-cla-bot bot added the CLA Signed label Mar 7, 2022

pcattori changed the title ~~Pedro/deno~~ Run Remix on Deno Mar 7, 2022

pcattori changed the base branch from main to dev March 7, 2022 16:33

pcattori force-pushed the pedro/deno branch 3 times, most recently from 7d8982d to ece1d63 Compare March 10, 2022 18:05

pcattori marked this pull request as ready for review March 10, 2022 22:10

pcattori requested review from jacob-ebey and mjackson March 10, 2022 22:10

pcattori force-pushed the pedro/deno branch 2 times, most recently from 4fe107c to f1421ee Compare March 14, 2022 23:20

pcattori commented Mar 14, 2022

View reviewed changes

jacob-ebey and others added 4 commits March 14, 2022 18:32

feat: added bundling of HTTP imports for browser build

88137f5

chore(cla): sign as pcattori

0c0d330

refactor(deno): do not include react shim for browser nor server build

893d2f5

react is always imported explicilty in deno when authoring react-based jsx (need to double check this)

pcattori force-pushed the pedro/deno branch from 2e6d850 to c79c20e Compare March 14, 2022 23:33

pcattori commented Mar 14, 2022

View reviewed changes

mjackson requested changes Mar 15, 2022

View reviewed changes

pcattori force-pushed the pedro/deno branch from 94fe048 to acbe3c9 Compare March 15, 2022 00:19

mjackson approved these changes Mar 15, 2022

View reviewed changes

pcattori force-pushed the pedro/deno branch from 9ef09eb to 47764b2 Compare March 15, 2022 00:37

pcattori and others added 3 commits March 14, 2022 19:41

fix(templates/deno): add working deno template

6859cf9

temporary scaffoling and known issues described in templates/deno/README.md

chore: update arc tarball fixture

e32b6fc

Signed-off-by: Logan McAnsh <logan@mcan.sh>

chore: update arc tarball fixture url

43161c8

Signed-off-by: Logan McAnsh <logan@mcan.sh>

pcattori force-pushed the pedro/deno branch from 47764b2 to 6e01ad3 Compare March 15, 2022 00:41

fix(@remix-run/dev): correct url for creating projects from templates

0ce2a26

currently referencing the dev branch, but should reference main branch for release

pcattori force-pushed the pedro/deno branch from 6e01ad3 to 0ce2a26 Compare March 15, 2022 00:49

test(@remix-run/dev): test tarball uses tsx, not jsx

828a4a6

pcattori merged commit a2427dd into dev Mar 15, 2022

pcattori deleted the pedro/deno branch March 15, 2022 01:42

This was referenced Mar 15, 2022

feat: switch deno template to use HTTP imports #2147

Closed

Remove unused mime dependency #2316

Merged

F3n67u reviewed Mar 22, 2022

View reviewed changes

renovate bot mentioned this pull request Jun 26, 2023

Update remix monorepo to v1.19.3 Bjenhamin4Alfredolvchenki/TEMPLATE_REMIX_PROJECT_MJSAY_FJHS3SFVUQJZs#230

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run Remix on Deno #2243

Run Remix on Deno #2243

pcattori commented Mar 7, 2022 •

edited

remix-cla-bot bot commented Mar 7, 2022

remix-cla-bot bot commented Mar 7, 2022

pcattori Mar 14, 2022 •

edited

pcattori Mar 15, 2022

mjackson Mar 15, 2022

MichaelDeBoey Mar 15, 2022

pcattori Mar 14, 2022 •

edited

mjackson left a comment

mjackson Mar 15, 2022

F3n67u Mar 22, 2022 •

edited

pcattori Mar 22, 2022 •

edited

pcattori Mar 22, 2022

Run Remix on Deno #2243

Run Remix on Deno #2243

Conversation

pcattori commented Mar 7, 2022 • edited

remix-cla-bot bot commented Mar 7, 2022

remix-cla-bot bot commented Mar 7, 2022

pcattori Mar 14, 2022 • edited

Choose a reason for hiding this comment

pcattori Mar 15, 2022

Choose a reason for hiding this comment

mjackson Mar 15, 2022

Choose a reason for hiding this comment

MichaelDeBoey Mar 15, 2022

Choose a reason for hiding this comment

pcattori Mar 14, 2022 • edited

Choose a reason for hiding this comment

mjackson left a comment

Choose a reason for hiding this comment

mjackson Mar 15, 2022

Choose a reason for hiding this comment

F3n67u Mar 22, 2022 • edited

Choose a reason for hiding this comment

pcattori Mar 22, 2022 • edited

Choose a reason for hiding this comment

pcattori Mar 22, 2022

Choose a reason for hiding this comment

pcattori commented Mar 7, 2022 •

edited

pcattori Mar 14, 2022 •

edited

pcattori Mar 14, 2022 •

edited

F3n67u Mar 22, 2022 •

edited

pcattori Mar 22, 2022 •

edited