Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(netlify): use Netlify internal functions dir #2291

Merged
merged 1 commit into from Mar 11, 2022

Conversation

ascorbic
Copy link
Contributor

This PR changes the Netlify template, and the default serverBuildPath to use the internal functions directory. This is preferred for frameworks because it is in a directory that is already gitignored, and does not interfere with the user's own functions. The redirects do not need changing, because the URL is unchanged.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 👍

@kentcdodds kentcdodds changed the title fix: use Netlify internal functions dir fix(netlify): use Netlify internal functions dir Mar 11, 2022
@kentcdodds kentcdodds merged commit d639603 into remix-run:dev Mar 11, 2022
@ascorbic ascorbic deleted the mk/nf-internal-functions branch March 14, 2022 09:16
jstafman pushed a commit to jstafman/remix that referenced this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants