Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(blog): add imports #2710

Merged
merged 4 commits into from
Apr 11, 2022
Merged

Conversation

accidentaldeveloper
Copy link
Contributor

Closes: #

  • Docs
  • Tests

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 9, 2022

Hi @accidentaldeveloper,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@accidentaldeveloper accidentaldeveloper marked this pull request as draft April 9, 2022 19:50
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 9, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@accidentaldeveloper
Copy link
Contributor Author

Encountered a missing import while following the tutorial. Haven't done full diligence yet but I definitely double checked to make sure it needed to be added.

@MichaelDeBoey MichaelDeBoey changed the title docs(blog) - Add necessary import docs(blog): add imports Apr 10, 2022
@machour
Copy link
Collaborator

machour commented Apr 10, 2022

Hi, thank you for submission! Are you done with this PR? It's still marked as a draft.

@accidentaldeveloper
Copy link
Contributor Author

accidentaldeveloper commented Apr 10, 2022

Hi, thank you for submission! Are you done with this PR? It's still marked as a draft.

@machour If you are happy with it, it can be merged but I haven't thoroughly confirmed it's correctness.

Just trying to be a good OSS citizen.

docs/tutorials/blog.md Outdated Show resolved Hide resolved
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks!

@kentcdodds kentcdodds marked this pull request as ready for review April 11, 2022 20:03
@kentcdodds kentcdodds merged commit d9b46a6 into remix-run:main Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants