Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pages/technical-explanation): update code highlighting #2717

Merged

Conversation

amorriscode
Copy link
Contributor

  • Docs

Description

While reading the technical explanation docs, it seemed like the code highlighting in the Browser Framework section was off. I believe the inside of the form should be highlighted as well as the FadeIn.

This PR updates the code highlighting to highlight the features discussed in the section.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 10, 2022

Hi @amorriscode,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 10, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title docs(technical-explanation): update code highlighting docs(pages/technical-explanation): update code highlighting Apr 10, 2022
@MichaelDeBoey MichaelDeBoey changed the base branch from dev to main April 10, 2022 17:57
@MichaelDeBoey MichaelDeBoey changed the base branch from main to dev April 10, 2022 17:57
@MichaelDeBoey
Copy link
Member

@amorriscode docs changes go to main. Can you please rebase your branch onto main & set base branch of the PR to main as well?

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label Apr 10, 2022
@amorriscode amorriscode force-pushed the amorriscode/update-code-highlights branch from da85e4a to e2d20ab Compare April 10, 2022 18:54
@amorriscode amorriscode changed the base branch from dev to main April 10, 2022 18:54
@amorriscode
Copy link
Contributor Author

@MichaelDeBoey done! Thanks for the quick response and fix of my mistake. 😳

@github-actions github-actions bot removed the needs-response We need a response from the original author about this issue/PR label Apr 10, 2022
@MichaelDeBoey MichaelDeBoey merged commit ef9e305 into remix-run:main Apr 10, 2022
@amorriscode amorriscode deleted the amorriscode/update-code-highlights branch April 10, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants