fix(remix-dev): Prioritize remix templates in CLI create #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaance
commented
Apr 11, 2022
| // 4. examples/<template> will use an example folder in the Remix repo | ||
| if (/^examples?\/[\w-]+$/.test(template)) { | ||
| return "example"; | ||
| } | ||
|
|
||
| // 5. If the string contains no slashes, spaces, or special chars, we assume | ||
| // it is one of our remix-run/remix/templates. | ||
| if (/^[\w-]+$/.test(template)) { |
There was a problem hiding this comment.
We don't need to do this check since we are verifying our templates statically. I think this is better anyway since we don't have too many and they're easy to verify without fetching.
mcansh
approved these changes
Apr 12, 2022
mcansh
changed the title
This was referenced Apr 14, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've received a few issues where folks would step through the interactive CLI, select one of our templates and end up with an unexpected result, largely because we always prioritize local files when detecting the input type.
Since local files are likely going to be used less frequently than our built-in stacks and templates, this PR checks for those options first and ensures that those inputs are not matched to local files/directories to avoid conflicts. If a local file or forked repo is desired, the user can pass the full path/URL accordingly.
Closes: #2491