feat(templates/deno): deploying to Deno Deploy #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcattori
force-pushed
the
pedro/deno-deploy
branch
3 times, most recently
from
7da0791
to
43be45f
Compare
pcattori
force-pushed
the
pedro/deno-deploy
branch
from
43be45f
to
d33cd7a
Compare
pcattori
force-pushed
the
pedro/deno-deploy
branch
2 times, most recently
from
343cc17
to
f64386d
Compare
MichaelDeBoey
requested changes
May 19, 2022
MichaelDeBoey
changed the title
pcattori
changed the title
pcattori
force-pushed
the
pedro/deno-deploy
branch
from
7f76c22
to
335d7bd
Compare
MichaelDeBoey
approved these changes
May 19, 2022
pcattori
force-pushed
the
pedro/deno-deploy
branch
from
335d7bd
to
84f08a8
Compare
pcattori
changed the title
MichaelDeBoey
approved these changes
May 20, 2022
pcattori
force-pushed
the
pedro/deno-deploy
branch
from
e13fcc9
to
84def56
Compare
pcattori
force-pushed
the
pedro/deno-deploy
branch
from
84def56
to
9975428
Compare
eastlondoner
pushed a commit
to eastlondoner/remix
that referenced
this pull request
Jun 8, 2022
* feat(templates/deno): deploy to deno deploy * feat(templates/deno): recommend the deno extension for vscode * docs(templates/deno): explain how to setup type hints within editor * ci(deno-deploy): add deploy test for deno deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing Strategy
Deployment test for Deno Deploy.
Tried the test locally by using my own Deno Deploy project name, and that deployed successfully. (https://salty-bee-35.deno.dev/)