Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bundle netlify-edge #2931

Conversation

ascorbic
Copy link
Contributor

Using URL imports for server runtime seems to be causing problems with conflicting versions of React. The best workaround looks like it is to bundle everything at build time, rather than trying to use Deno URL imports. This PR changes the runtime from being distributes as TypeScript source for Deno, and instead bundles it like other runtimes. The generated server functions are still Deno-compatible, but it no longer imports anything from esm.sh etc.

Closes: #

  • Docs
  • Tests

@chaance chaance merged commit 1c68983 into remix-run:experimental-netlify-edge Apr 20, 2022
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-a9f2dde-20220426 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-cc69c1b-20220427 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v1.4.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v1.4.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants