docs(example): add an example of using flash session #3043
Conversation
|
Hi @michaeldebetaz, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 馃コ |
| <form method="dialog"> | ||
| <button>Close</button> | ||
| </form> |
There was a problem hiding this comment.
Can you help me understand this? I've never see method="dialog" before. Is this just a part of the form spec I've never heard of before?
There was a problem hiding this comment.
looks like there is https://developer.mozilla.org/en-US/docs/Web/HTML/Element/form#attr-method 馃く
There was a problem hiding this comment.
Thanks for accepting my modest contribution 馃檹 I went a bit overboard with the #useThePlatform thing 馃構
I wanted to use the opportunity of my example to make other people learn surprising things on the way.
I wasn't sure about , as it isn't supported by Typescript yet (I had to import my own interface). But it's definitely nice to know a native way to create dialogs and modals without relying on Javascript.
In my case, I was more mind-blowned by color-scheme: dark light which use the browser for applying native dark theme (if preferred) without any additionnal CSS 馃く
Should I add a section to explain my Easter eggs?
There was a problem hiding this comment.
Actually I almost asked you to remove that bit because we normally want to keep things as simple and focused as possible. I don't think we need to explain those things. Thanks though!
There was a problem hiding this comment.
Thank you then. I'll try to keep it more concise next time! I just didn't want to reproduce the exact same example as the one already in your docs 馃構
I'll see where my current project takes me, I would love to contribute again 馃敟
kentcdodds
added
the
needs-response
MichaelDeBoey
removed
the
needs-response
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Creating an example for session.flash() a bit more advanced than what is in the Remix Docs. For example, I added the use of the element and a strategy to dynamically style the flash message.
This is my very first PR. Let me know if I could improve some things for my next PRs.
Thanks a lot. Remix rox. You guys are legends 馃槈