Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api/conventions): fix typos #3077

Merged
merged 2 commits into from
May 3, 2022
Merged

docs(api/conventions): fix typos #3077

merged 2 commits into from
May 3, 2022

Conversation

JulesBlm
Copy link
Contributor

@JulesBlm JulesBlm commented May 3, 2022

I think the comment // content => name was swapped around and // name => content is more logical, as the key is the name and the value is the property.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 3, 2022

Hi @JulesBlm,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 3, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title docs(api): Fix typo, switch order of name & content docs(api/conventions): fix typos May 3, 2022
@MichaelDeBoey MichaelDeBoey merged commit 96299f6 into remix-run:main May 3, 2022
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 10, 2022
* Fix typo, switch order of name & content

* Update contributors.yml
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 12, 2022
* Fix typo, switch order of name & content

* Update contributors.yml
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 15, 2022
* Fix typo, switch order of name & content

* Update contributors.yml
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 16, 2022
* Fix typo, switch order of name & content

* Update contributors.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants