fix(templates/vercel): add index.js.map to .gitignore
#3216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Vercel template, `/api/index.js.map` should also be ignored along with `/api/index.js`. Otherwise, that mapping file would be committed into version control, which is not desired.
|
Hi @jiahao-c, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
MichaelDeBoey
changed the title
index.js.map to .gitignoreindex.js.map to .gitignore
jiahao-c
changed the title
index.js.map to .gitignoreindex.js.map to .gitignore
MichaelDeBoey
approved these changes
May 17, 2022
pcattori
added a commit
that referenced
this pull request
May 19, 2022
* fix(templates/vercel): add `index.js.map` to `.gitignore` (#3216) * Add `index.js.map` to `.gitignore` In the Vercel template, `/api/index.js.map` should also be ignored along with `/api/index.js`. Otherwise, that mapping file would be committed into version control, which is not desired. * Sign CLA * fix(scripts): Prevent publishing without a tag (#3223) * move decisions * docs: add `decisions/index.md` and frontmatter (#3226) Co-authored-by: Pedro Cattori <pcattori@gmail.com> (cherry picked from commit e809206) * docs(server-runtime): update link for deno server runtime package (#3228) since it's now a proper package * chore(templates): bring `deno` template in line with other templates (#3221) * docs: fix links to decision docs (#3231) * chore: update Deno import maps on release Co-authored-by: Jiahao <8275280+jiahao-c@users.noreply.github.com> Co-authored-by: Chance Strickland <hi@chance.dev> Co-authored-by: Ryan Florence <rpflorence@gmail.com> Co-authored-by: Logan McAnsh <logan@mcan.sh> Co-authored-by: Pedro Cattori <pcattori@gmail.com>
christophertrudel
pushed a commit
to christophertrudel/remix
that referenced
this pull request
May 21, 2022
* fix(templates/vercel): add `index.js.map` to `.gitignore` (remix-run#3216) * Add `index.js.map` to `.gitignore` In the Vercel template, `/api/index.js.map` should also be ignored along with `/api/index.js`. Otherwise, that mapping file would be committed into version control, which is not desired. * Sign CLA * fix(scripts): Prevent publishing without a tag (remix-run#3223) * move decisions * docs: add `decisions/index.md` and frontmatter (remix-run#3226) Co-authored-by: Pedro Cattori <pcattori@gmail.com> (cherry picked from commit e809206) * docs(server-runtime): update link for deno server runtime package (remix-run#3228) since it's now a proper package * chore(templates): bring `deno` template in line with other templates (remix-run#3221) * docs: fix links to decision docs (remix-run#3231) * chore: update Deno import maps on release Co-authored-by: Jiahao <8275280+jiahao-c@users.noreply.github.com> Co-authored-by: Chance Strickland <hi@chance.dev> Co-authored-by: Ryan Florence <rpflorence@gmail.com> Co-authored-by: Logan McAnsh <logan@mcan.sh> Co-authored-by: Pedro Cattori <pcattori@gmail.com>
eastlondoner
pushed a commit
to eastlondoner/remix
that referenced
this pull request
Jun 8, 2022
…3216) * Add `index.js.map` to `.gitignore` In the Vercel template, `/api/index.js.map` should also be ignored along with `/api/index.js`. Otherwise, that mapping file would be committed into version control, which is not desired. * Sign CLA
justjavac
pushed a commit
to justjavac/remix
that referenced
this pull request
Jun 11, 2022
* fix(templates/vercel): add `index.js.map` to `.gitignore` (remix-run#3216) * Add `index.js.map` to `.gitignore` In the Vercel template, `/api/index.js.map` should also be ignored along with `/api/index.js`. Otherwise, that mapping file would be committed into version control, which is not desired. * Sign CLA * fix(scripts): Prevent publishing without a tag (remix-run#3223) * move decisions * docs: add `decisions/index.md` and frontmatter (remix-run#3226) Co-authored-by: Pedro Cattori <pcattori@gmail.com> (cherry picked from commit e809206) * docs(server-runtime): update link for deno server runtime package (remix-run#3228) since it's now a proper package * chore(templates): bring `deno` template in line with other templates (remix-run#3221) * docs: fix links to decision docs (remix-run#3231) * chore: update Deno import maps on release Co-authored-by: Jiahao <8275280+jiahao-c@users.noreply.github.com> Co-authored-by: Chance Strickland <hi@chance.dev> Co-authored-by: Ryan Florence <rpflorence@gmail.com> Co-authored-by: Logan McAnsh <logan@mcan.sh> Co-authored-by: Pedro Cattori <pcattori@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Vercel template,
/api/index.js.mapshould also be ignored along with/api/index.js. Otherwise, that mapping file would be committed into version control, which is not desired.This PR only touches
/templates, therefore requesting merge atmaininstead ofdevbranch.Testing Strategy:
git commit