Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): add link to EdgeDB variant of jokes example #3268

Merged
merged 5 commits into from
May 22, 2022

Conversation

colinhacks
Copy link
Contributor

Adding a variant of the jokes example that uses EdgeDB instead of SQLite/Prisma.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 20, 2022

Hi @colinhacks,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 20, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@machour
Copy link
Collaborator

machour commented May 20, 2022

Thank you for pulling this example together @colinhacks !

My first sentiment is that the example should focus solely on the EdgeDb part (and drop the metas, etc) but since this is an adaptation of the jokes tutorials, not sure how we would like to handle this.

What would @kentcdodds do?

@MichaelDeBoey MichaelDeBoey changed the title Add EdgeDB example docs(examples): add EdgeDB example May 21, 2022
@MichaelDeBoey
Copy link
Member

I would personally make all the examples as small as possible & only focus on what technology your trying to show.

blog & jokes examples are an exception imo, as they both have a full blown tutorial written for them as well.

@kentcdodds
Copy link
Member

Agreed!

I do feel like there's value here though. Here's what I suggest @colinhacks: put this example in your personal repo and update the README of the jokes example to point to yours as a comparison.

May be interesting to start your git repo with the original jokes app and make a branch with that, then update to EdgeDB and link people to a diff.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one thing.

examples/jokes/README.md Outdated Show resolved Hide resolved
@colinhacks colinhacks force-pushed the edgedb-example branch 4 times, most recently from 0e17b34 to 0e31e32 Compare May 22, 2022 06:42
@MichaelDeBoey MichaelDeBoey changed the title docs(examples): add EdgeDB example docs(examples): add link to EdgeDB variant of jokes example May 22, 2022
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Thanks!

@kentcdodds kentcdodds merged commit 88111b4 into remix-run:main May 22, 2022
eastlondoner pushed a commit to eastlondoner/remix that referenced this pull request Jun 8, 2022
…x-run#3268)

* Add EdgeDB example

* Add name to contributors

* Finalize README

* Update readme

* Add mention of EdgeDB jokes variant to readme
eastlondoner pushed a commit to eastlondoner/remix that referenced this pull request Jun 8, 2022
…x-run#3268)

* Add EdgeDB example

* Add name to contributors

* Finalize README

* Update readme

* Add mention of EdgeDB jokes variant to readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants