Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stop publishing @remix-run/init, start publishing create-remix #338

Merged
merged 14 commits into from Oct 21, 2021
Merged

feat: stop publishing @remix-run/init, start publishing create-remix #338

merged 14 commits into from Oct 21, 2021

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Oct 19, 2021 •
edited

closes REM-440

@mcansh mcansh requested a review from mjackson October 19, 2021 15:38
@mcansh mcansh self-assigned this Oct 19, 2021
@mcansh
chore: update 'that\'s it' message when appDir is the current directory
74d3f1f 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: use version from cli package.json
587e342 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: update references to npm init remix to `npx create-remix@lat…
12c102e 
…est`

Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: update npmrc handling
7e0d37f 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh changed the title [WIP] chore: stop publishing @remix-run/init, start publishing create-remix feat: stop publishing @remix-run/init, start publishing create-remix Oct 20, 2021
@mcansh mcansh requested review from chaance, jacob-ebey and mjackson and removed request for mjackson, chaance and jacob-ebey October 20, 2021 01:10
@mcansh
chore: remove tag flag as you just use npx create-remix@{tag} now
b67fb37 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
fixup! chore: remove tag flag as you just use `npx create-remix@{tag}…
23daa9e 
…` now

Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: rename pkgJson to cliPkgJson to avoid confusion
9bc33cd 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: always write local npmrc file
869ae0a 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
mjackson
mjackson requested changes Oct 21, 2021
View reviewed changes
Copy link
Member

@mjackson mjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work here, @mcansh. Thank you! Just one small comment about getting rid of mentions of the auth tokens everywhere.

packages/create-remix/templates/vercel/README.md Outdated Show resolved Hide resolved
@mcansh
Copy link
Collaborator Author

mcansh commented Oct 21, 2021

ahhh it's happening!

@mcansh mcansh merged commit 9229117 into dev Oct 21, 2021
@mcansh mcansh deleted the logan/REM-440-rework-create-remix branch October 21, 2021 19:02
edmundhung added a commit to edmundhung/remix-sandbox that referenced this pull request Nov 1, 2021
@edmundhung
fix: update scripts as per changes on remix-run/remix#338
c3e7a6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjackson mjackson mjackson approved these changes

Assignees

@mcansh mcansh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcansh @mjackson