enhancement(dev/cli): Add --port flag to remix dev
#3447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
approved these changes
Jun 10, 2022
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
kentcdodds
reviewed
Jun 14, 2022
Comment on lines
+237
to
+241
| export async function dev( | ||
| remixRoot: string, | ||
| modeArg?: string, | ||
| portArg?: number | ||
| ) { |
There was a problem hiding this comment.
If we need to add one more arg to this in the future let's turn this into a single options argument.
This was referenced Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
--portflag toremix devthat takes precedence overprocess.env.PORT. This makes it easier to choose a new port on the fly.Note, I updated the snapshot but didn't create any new tests yet. We don't currently have a test suite for
remix devcommands and I need to follow up internally before adding a new process-intensive test that could further slow things down in CI. I did test it manually and things work as expected.