Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api/remix): add note to sessions usage section #3458

Merged
merged 4 commits into from
Jun 21, 2022

Conversation

davecranwell-vocovo
Copy link
Contributor

Adds caveat around use of the code verbatim, as using expires in the way shown, outside any kind of dynamic function, would result in a fixed expiry for all future cookies

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 13, 2022

Hi @davecranwell-vocovo,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@MichaelDeBoey MichaelDeBoey changed the title Update remix.md docs(api/remix): add note to sessions usage section Jun 13, 2022
docs/api/remix.md Outdated Show resolved Hide resolved
@MichaelDeBoey
Copy link
Member

@davecranwell-vocovo Please also sign the CLA.
Without doing so, we can't merge this PR.

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label Jun 13, 2022
docs/api/remix.md Outdated Show resolved Hide resolved
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 15, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey self-requested a review June 15, 2022 22:08
davecranwell-vocovo and others added 4 commits June 16, 2022 00:08
Adds caveat around use of the code verbatim, as using `expires` in the way shown, outside any kind of dynamic function, would result in a fixed expiry for all future cookies
Co-authored-by: Mehdi Achour <machour@gmail.com>
@MichaelDeBoey MichaelDeBoey removed the needs-response We need a response from the original author about this issue/PR label Jun 15, 2022
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants