-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(api/remix): add note to sessions usage section #3458
Conversation
Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
@davecranwell-vocovo Please also sign the CLA. |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Adds caveat around use of the code verbatim, as using `expires` in the way shown, outside any kind of dynamic function, would result in a fixed expiry for all future cookies
Co-authored-by: Mehdi Achour <machour@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call.
Adds caveat around use of the code verbatim, as using
expires
in the way shown, outside any kind of dynamic function, would result in a fixed expiry for all future cookies