Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(remix-dev): add failing test for 'multiple routes with the same route module' #1898 #3684

Closed
wants to merge 4 commits into from

Conversation

AndrewLeedham
Copy link
Contributor

Closes: #1898

  • Docs
  • Tests

Testing Strategy:

I added a failing test to show that multiple routes pointing at a single route module get overwritten.

@changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2022

⚠️ No Changeset found

Latest commit: d74933f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 8, 2022

Hi @AndrewLeedham,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@AndrewLeedham AndrewLeedham changed the base branch from main to dev July 8, 2022 16:54
@machour
Copy link
Collaborator

machour commented Jul 11, 2022

@AndrewLeedham can you please sign the CLA so that we can run the failing test?
Also consider removing the draft state if you're done :)

@machour machour added the needs-response We need a response from the original author about this issue/PR label Jul 11, 2022
@AndrewLeedham
Copy link
Contributor Author

@AndrewLeedham can you please sign the CLA so that we can run the failing test? Also consider removing the draft state if you're done :)

@machour I plan to do both, I just haven't got clearance from my company yet.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 13, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@AndrewLeedham AndrewLeedham marked this pull request as ready for review July 13, 2022 14:00
@AndrewLeedham
Copy link
Contributor Author

@MichaelDeBoey I tried fixing this, but it seems like changing IDs would be a breaking change. Where would be best to discuss this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defining multiple routes with same route module
3 participants