Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-react): fix <Form> submit to not break formMethod functionality #4053

Merged
merged 13 commits into from
Oct 13, 2022
Merged

fix(remix-react): fix <Form> submit to not break formMethod functionality #4053

merged 13 commits into from
Oct 13, 2022

Commits on Jun 29, 2022

  1. test: failing test with <Form> not respecting formMethod

    Bug report integration test demonstrating how the `<Form>` component –
    unlike native `<form>` - does not respect the `formmethod` attribute set
    on the submitter (the `<button>` submitting the form).
    nrako committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    06333c1 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. fix(remix-react): submit <Form> w/method set by submitter formmethod

    Fix `<Form>` component by not passing the form's `method` into the
    `options` when calling the `submit(target, options)` function (created
    with the `useSubmit()` hook). This ensures that the option does not take
    precedence on any `formethod` set on the submitter which otherwise break
    the `formmethod` functionality.
    
    Since #3094 and #3094 the `<Form>` passes the "submitter" (if any) as
    the `target` to the `submit(target, options)` (`useSubmitImpl`) which
    will attempt to read the `formmethod`, `formaction` and `formenctype`
    attributes on the target. Therefore, the responsability to infer which
    method should be used should solely be on `useSubmitImpl` for the given
    `target`.
    
    Co-authored-by: Maxime Doury <maxime.doury@docavenue.com>
    nrako and Maxime Doury committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    9360e17 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. readded tests from (#2162)

    kevlened committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    6ea7b91 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2213fc5 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. Update integration/form-test.ts

    Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
    kevlened and MichaelDeBoey committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    0739e07 View commit details
    Browse the repository at this point in the history
  2. Update integration/form-test.ts

    Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
    kevlened and MichaelDeBoey committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    e274c21 View commit details
    Browse the repository at this point in the history
  3. Update integration/form-test.ts

    Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
    kevlened and MichaelDeBoey committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    71c8b4c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7cc9f16 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5ab94a4 View commit details
    Browse the repository at this point in the history
  6. consistent test text

    kevlened committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    2a5d291 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Configuration menu
    Copy the full SHA
    fc0131e View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Configuration menu
    Copy the full SHA
    dfe0dbf View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Create lovely-cats-jump.md

    mcansh committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    4028ab5 View commit details
    Browse the repository at this point in the history