-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix-react): fix <Form>
submit to not break formMethod
functionality
#4053
Commits on Jun 29, 2022
-
test: failing test with
<Form>
not respectingformMethod
Bug report integration test demonstrating how the `<Form>` component – unlike native `<form>` - does not respect the `formmethod` attribute set on the submitter (the `<button>` submitting the form).
Configuration menu - View commit details
-
Copy full SHA for 06333c1 - Browse repository at this point
Copy the full SHA 06333c1View commit details
Commits on Jun 30, 2022
-
fix(remix-react): submit
<Form>
w/method set by submitterformmethod
Fix `<Form>` component by not passing the form's `method` into the `options` when calling the `submit(target, options)` function (created with the `useSubmit()` hook). This ensures that the option does not take precedence on any `formethod` set on the submitter which otherwise break the `formmethod` functionality. Since #3094 and #3094 the `<Form>` passes the "submitter" (if any) as the `target` to the `submit(target, options)` (`useSubmitImpl`) which will attempt to read the `formmethod`, `formaction` and `formenctype` attributes on the target. Therefore, the responsability to infer which method should be used should solely be on `useSubmitImpl` for the given `target`. Co-authored-by: Maxime Doury <maxime.doury@docavenue.com>
Configuration menu - View commit details
-
Copy full SHA for 9360e17 - Browse repository at this point
Copy the full SHA 9360e17View commit details
Commits on Aug 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6ea7b91 - Browse repository at this point
Copy the full SHA 6ea7b91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2213fc5 - Browse repository at this point
Copy the full SHA 2213fc5View commit details
Commits on Aug 26, 2022
-
Update integration/form-test.ts
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
Configuration menu - View commit details
-
Copy full SHA for 0739e07 - Browse repository at this point
Copy the full SHA 0739e07View commit details -
Update integration/form-test.ts
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
Configuration menu - View commit details
-
Copy full SHA for e274c21 - Browse repository at this point
Copy the full SHA e274c21View commit details -
Update integration/form-test.ts
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
Configuration menu - View commit details
-
Copy full SHA for 71c8b4c - Browse repository at this point
Copy the full SHA 71c8b4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cc9f16 - Browse repository at this point
Copy the full SHA 7cc9f16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ab94a4 - Browse repository at this point
Copy the full SHA 5ab94a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a5d291 - Browse repository at this point
Copy the full SHA 2a5d291View commit details
Commits on Sep 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fc0131e - Browse repository at this point
Copy the full SHA fc0131eView commit details
Commits on Sep 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for dfe0dbf - Browse repository at this point
Copy the full SHA dfe0dbfView commit details
Commits on Sep 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4028ab5 - Browse repository at this point
Copy the full SHA 4028ab5View commit details