Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): build modules for ts->js conversion #4891

Merged
merged 2 commits into from Dec 16, 2022
Merged

fix(dev): build modules for ts->js conversion #4891

merged 2 commits into from Dec 16, 2022

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Dec 16, 2022 •
edited

Closes: #4854

TODO

  • Test out locally
  • Investigate why the changeset bot thinks there's a changeset for this PR
  • Add an actual changeset

@pcattori
fix(dev): build js modules for ts->js conversion
84a9c49 
The TS->JS migration was removed from the CLI codemod options, but still
used for TS->JS conversion when creating a new Remix project from the
CLI. The TS modules responsible for the TS->JS conversion were
incorrectly removed from the Rollup build, resulting in the
corresponding built JS modules being absent. That caused the CLI to
error when trying to perform TS->JS conversion. This changes
reintroduces the wiring to build the modules responsible for the TS->JS
conversion.

Fixes #4854
@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2022 •
edited

🦋 Changeset detected

Latest commit: a63be39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori changed the base branch from main to dev December 16, 2022 16:27
@pcattori pcattori marked this pull request as draft December 16, 2022 16:30
@pcattori pcattori marked this pull request as ready for review December 16, 2022 16:47
@pcattori pcattori merged commit eb818e4 into dev Dec 16, 2022
@pcattori pcattori deleted the pedro/fix-ts-to-js-conversion branch December 16, 2022 16:59
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Dec 16, 2022
@pcattori pcattori mentioned this pull request Dec 16, 2022
Closed
This was referenced Dec 16, 2022
Closed
Closed
Merged
This was referenced Jan 9, 2023
Merged
Closed
This was referenced Jan 21, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees
No one assigned
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npx create-remix@latest error
2 participants
@pcattori @MichaelDeBoey