Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #496 #542

Closed
wants to merge 2 commits into from
Closed

fix #496 #542

wants to merge 2 commits into from

Conversation

arpitdalal
Copy link

Fix #496.

Fix:

Replace the broken link with this link in examples/basic/app/routes/demos/about.tsx and examples/blog-tutorial/app/routes/demos/about.tsx examples.

@@ -31,7 +31,7 @@ export default function Index() {
<p>
Wait a sec...<em>its children</em>? To understand what we mean by
this,{" "}
<a href="https://remix.run/tutorial/4-nested-routes-params">
<a href="https://remix.run/docs/en/dev/guides/routing#what-are-nested-routes">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="https://remix.run/docs/en/dev/guides/routing#what-are-nested-routes">
<a href="https://remix.run/docs/en/v1/guides/routing#what-are-nested-routes">

@@ -31,7 +31,7 @@ export default function Index() {
<p>
Wait a sec...<em>its children</em>? To understand what we mean by
this,{" "}
<a href="https://remix.run/tutorial/4-nested-routes-params">
<a href="https://remix.run/docs/en/dev/guides/routing#what-are-nested-routes">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="https://remix.run/docs/en/dev/guides/routing#what-are-nested-routes">
<a href="https://remix.run/docs/en/v1/guides/routing#what-are-nested-routes">

@ryanflorence
Copy link
Member

Thank you for your help, but it looks like we've already fixed this.

If I'm wrong, please re-open this issue and we'll get it sorted out. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants