Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step to quickstart #560

Merged
merged 4 commits into from Dec 2, 2021
Merged

Add step to quickstart #560

merged 4 commits into from Dec 2, 2021

Conversation

VictorPeralta
Copy link
Contributor

@VictorPeralta VictorPeralta commented Nov 24, 2021

I was reading along and got a bit disoriented when I read There's a bit going on in the file..., and didn't know what file I was supposed to be in. One can quickly figure it out when you continue to read below, but I think adding 馃捒 First, go to app/root.tsx will spare readers of a few seconds of confusion

I was reading along and got a bit disoriented when I read `There's a bit going on in the file...`, and didn't know what file I was supposed to be in. One can quickly figure it out when you continue to read below, but I think adding `馃捒 First, go to `app/root.tsx`` will spare readers of a few seconds of confusion
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 24, 2021

Hi @VictorPeralta,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 24, 2021

Thank you for signing the Contributor License Agreement. Let's get this merged! 馃コ

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 馃憤 Thanks!

@kentcdodds kentcdodds merged commit c8657b3 into remix-run:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants