chore: don't log server errors for aborted requests #5602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 71f1a8f The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Feb 28, 2023
| @@ -383,10 +389,6 @@ async function errorBoundaryError(error: Error, status: number) { | |||
| } | |||
|
|
|||
| function returnLastResortErrorResponse(error: any, serverMode?: ServerMode) { | |||
| if (serverMode !== ServerMode.Test) { | |||
| console.error(error); | |||
| } | |||
There was a problem hiding this comment.
Moved the log to a utility that does the checking and lifted to the 2 places we call returnLastResortErrorResponse
jacob-ebey
approved these changes
Mar 9, 2023
MichaelDeBoey
approved these changes
Mar 10, 2023
github-actions
bot
added
the
awaiting release
|
🤖 Hello there, We just published version Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since aborted requests is an ecpedted flow, we should not log the error from the router (i.e.,
new Error("queryRoute() call aborted")). We had this check for some flows but not all.