Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(remix-node): bump @remix-run/web-fetch to latest #6120

Merged
merged 6 commits into from
Apr 25, 2023
Merged

chore(remix-node): bump @remix-run/web-fetch to latest #6120

merged 6 commits into from
Apr 25, 2023

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Apr 20, 2023 •
edited
Loading

fixes TypeError: Value of "this" must be of type URLSearchParams on Node 20

looks like node 20 also changes how our Headers polyfill is rendered via jest's toMatchInlineSnapshot as this is the result of tests

- "headers": Headers {
-   Symbol(query): Array [
-     "cache-control",
-     "max-age=300, s-maxage=3600",
-     "x-forwarded-host",
-     "localhost:3000",
-     "x-forwarded-proto",
-     "http",
-   ],
-   Symbol(context): null,
- },
+ "headers": Headers {},

Closes #6118

@mcansh
chore(remix-node): bump @remix-run/web-fetch to latest
7c796bd 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9b2f348

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcansh
ci: use latest node
29b9d5b 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@numandev1
Copy link

@MichaelDeBoey when it will in released version?

@mcansh
test: update tests as node 20 has changed the result
2ffdece 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh changed the title chore(remix-node): bump @remix-run/web-fetch to latest chore(remix-node): bump @remix-run/web-fetch to latest Apr 24, 2023
@mcansh mcansh self-assigned this Apr 24, 2023
@mcansh mcansh linked an issue Apr 24, 2023 that may be closed by this pull request
Node 20: Running any remix app returns TypeError: Value of "this" must be of type URLSearchParams #6118
Closed
1 task
@mcansh
test: update bad method test
1af4d74 
it now throws a TypeError

Signed-off-by: Logan McAnsh <logan@mcan.sh>
mcansh
mcansh commented Apr 24, 2023
View reviewed changes
integration/error-data-request-test.ts
Comment on lines +132 to 138
expect(() =>
fixture.requestData("/loader-return-json", "routes/loader-return-json", {
method: "TRACE",
}
})
).rejects.toThrowError(
`Failed to construct 'Request': 'TRACE' HTTP method is unsupported.`
);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this now throws as of 4.3.2 of web-fetch remix-run/web-std-io#30

@mcansh
test: update tests to test specific return values
7b69e3b 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
test: remove inline snapshots for requests/responses
9b2f348 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh requested a review from jacob-ebey April 25, 2023 00:43
@mcansh mcansh merged commit 37d8b7d into dev Apr 25, 2023
@mcansh mcansh deleted the logan/node-20 branch April 25, 2023 17:27
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Apr 25, 2023
mcansh added a commit that referenced this pull request May 2, 2023
@mcansh
ci: node latest works now
2ed83d7 
lost during a merge

#6120
mcansh added a commit that referenced this pull request May 2, 2023
@mcansh
ci: node latest works now
10b0399 
lost during a merge

#6120
(cherry picked from commit 2ed83d7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@jacob-ebey jacob-ebey Awaiting requested review from jacob-ebey

Assignees

@mcansh mcansh

Labels
awaiting release This issue has been fixed and will be released soon CLA Signed runtime:node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node 20: Running any remix app returns TypeError: Value of "this" must be of type URLSearchParams
3 participants
@mcansh @numandev1 @MichaelDeBoey