-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(remix-node): bump @remix-run/web-fetch
to latest
#6120
Conversation
Signed-off-by: Logan McAnsh <logan@mcan.sh>
|
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@MichaelDeBoey when it will in released version? |
27e6d76
to
e653677
Compare
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@remix-run/web-fetch
to latest
it now throws a TypeError Signed-off-by: Logan McAnsh <logan@mcan.sh>
expect(() => | ||
fixture.requestData("/loader-return-json", "routes/loader-return-json", { | ||
method: "TRACE", | ||
} | ||
}) | ||
).rejects.toThrowError( | ||
`Failed to construct 'Request': 'TRACE' HTTP method is unsupported.` | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this now throws as of 4.3.2 of web-fetch remix-run/web-std-io#30
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
fixes
TypeError: Value of "this" must be of type URLSearchParams
on Node 20looks like node 20 also changes how our Headers polyfill is rendered via jest's
toMatchInlineSnapshot
as this is the result of testsCloses #6118