Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplified types for useLoaderData, useActionData, useFetcher, SerializeFrom #6449

Merged
merged 1 commit into from May 22, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented May 22, 2023

Prototype:

Screenshot_2023-05-02_at_4 49 26_PM

Usage:

Screenshot 2023-05-22 at 10 36 49 AM

@changeset-bot
Copy link

changeset-bot bot commented May 22, 2023

🦋 Changeset detected

Latest commit: 30cedcd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/server-runtime Minor
@remix-run/react Minor
@remix-run/cloudflare Minor
@remix-run/deno Minor
@remix-run/dev Minor
@remix-run/node Minor
@remix-run/testing Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
create-remix Minor
@remix-run/css-bundle Minor
@remix-run/architect Minor
@remix-run/express Minor
@remix-run/netlify Minor
@remix-run/serve Minor
@remix-run/vercel Minor
remix Minor
@remix-run/eslint-config Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori force-pushed the pedro/pretty-serialize-from branch from 2adf546 to 30cedcd Compare May 22, 2023 14:28
@pcattori pcattori changed the title feat: simplified types for SerializeFrom feat: simplified types for Serialize (useLoaderData, useActionData, useFetcher, SerializeFrom) May 22, 2023
@pcattori pcattori changed the title feat: simplified types for Serialize (useLoaderData, useActionData, useFetcher, SerializeFrom) feat: simplified types for useLoaderData, useActionData, useFetcher, SerializeFrom May 22, 2023
@pcattori pcattori merged commit d56574b into dev May 22, 2023
9 checks passed
@pcattori pcattori deleted the pedro/pretty-serialize-from branch May 22, 2023 15:20
@juanpprieto
Copy link

This is great to see <3. Will this impact/simplify defer types too?

@pcattori
Copy link
Contributor Author

This is great to see <3. Will this impact/simplify defer types too?

Hey JP 👋

Yes, SerializeDeferred is handled as a subcase of Serialize, so those types should be nicer as well.

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-d56574b-20230523 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@dev-xo
Copy link

dev-xo commented Jun 10, 2023

Thank you for this one @pcattori!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants