Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev): stabilize v2 dev server #6615

Merged
merged 4 commits into from Jun 16, 2023
Merged

feat(dev): stabilize v2 dev server #6615

merged 4 commits into from Jun 16, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Jun 15, 2023

See new docs

@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2023

🦋 Changeset detected

Latest commit: b640a6b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor
create-remix Minor
@remix-run/cloudflare Minor
@remix-run/deno Minor
@remix-run/node Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/architect Minor
@remix-run/express Minor
@remix-run/netlify Minor
@remix-run/vercel Minor
remix Minor
@remix-run/css-bundle Minor
@remix-run/eslint-config Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori force-pushed the pedro/v2_dev branch 3 times, most recently from 8cf850d to 6b53573 Compare June 15, 2023 18:53
@pcattori pcattori changed the title docs(v2_dev): instructions for using and migrating to v2_dev feat(dev): stabilize v2 dev server Jun 15, 2023
@pcattori pcattori merged commit 28cdbf2 into dev Jun 16, 2023
9 checks passed
@pcattori pcattori deleted the pedro/v2_dev branch June 16, 2023 21:50
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jun 16, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-382edbe-20230617 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@xHomu
Copy link
Contributor

xHomu commented Jun 18, 2023

Can confirm about 25% improvement in rebuild time (3.2s -> 2.5s) on an WIndows i7-7700 setup with the latest nightly build!

Before v1.17.0

image

After 0.0.0-nightly-25620b9-20230618

image

#6539 @lili21 can you confirm?

@lili21
Copy link
Contributor

lili21 commented Jun 19, 2023

can confirm, rebuild time goes down from 1.9 to 1.4s。

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.18.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@xHomu
Copy link
Contributor

xHomu commented Jun 21, 2023

I been noticing random app crashes with v0.0.0-nightly-aa896a4-20230619 and 1.18.0-pre.0:

image

They don't seem to happen with 0.0.0-nightly-25620b9-20230618.

I'm not able to reproduce this error consistently enough to nail down its cause, unfortunately. Will report back if anything changes.

@pcattori
Copy link
Contributor Author

@xHomu can you console.log(build) right before you call broadcastDevReady? Curious what that looks like since it should have a assets.version set.

@xHomu
Copy link
Contributor

xHomu commented Jun 21, 2023

@xHomu can you console.log(build) right before you call broadcastDevReady? Curious what that looks like since it should have a assets.version set.

@pcattori This is on an CJS app, so we're using require(BUILD_DR) instead: https://github.com/manawiki/starrail/blob/main/core.server.ts

Output from adding console.log(require(BUILD_DIR)):

image

EDIT

image

Seems to be working fine?

@xHomu
Copy link
Contributor

xHomu commented Jun 21, 2023

@pcattori I'm not sure if it's entirely related, but I noticed another weird bug introduced between 0.0.0-nightly-25620b9-20230618 and 1.18.0-pre.0.

Weird .css.map error with chrome devtools on:

image
something wrong

Seems like it's expecting a sourcemap file for .css as well?

This one is reproduceable, you should able build this locally if you still have the .env I sent from before https://github.com/manawiki/starrail/tree/remix_v1.18_pre_bug

Above error shows on Windows with devtools on, switch to 0.0.0-nightly-25620b9-20230618 the error goes away.

@pcattori
Copy link
Contributor Author

@xHomu if you are still encountering these issues, could you create separate GitHub issues?

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.18.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants