Use superjson to stringify and parse data between server and client #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
force-pushed
the
dev
branch
2 times, most recently
from
ab9dac4
to
172ecc9
Compare
|
This seems pretty sweet. Would be a breaking change so we'd probably want to start with a config option to enable this. Probably would want it to be unstable. Even before that, a remix-superjson lib would be good for folks to try it out in real apps. In any case, I can't say that we're going to merge this, but those are just a few of my thoughts. |
|
Let's open a discussion for this. I think I like it? |
There’s an issue here #656, maybe convert it to discussion? |
|
Done: #1910 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #656
This implements the Blitz.js superjson library to serialize and parse values.
This way if a loader or action returns
undefined, BigInt, Date, RegExp, Set, Map or Error objects the useLoaderData will receive the instance of those objects instead of a string or on error because JSON.stringify can't serialize them.