chore(templates): integrate v2_dev #6650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pcattori
force-pushed
the
pedro/v2-dev-templates
branch
2 times, most recently
from
bb0e8a5
to
512467d
Compare
this is a workaround while we figure out why arc not able to opt out of their built-in reloads
pcattori
force-pushed
the
pedro/v2-dev-templates
branch
from
30dd4c5
to
2faa8c2
Compare
huw
reviewed
Jun 23, 2023
| @@ -1,10 +1,12 @@ | |||
| /** @type {import('@remix-run/dev').AppConfig} */ | |||
| module.exports = { | |||
| devServerBroadcastDelay: 1000, | |||
| export default { | |||
| ignoredRouteFiles: ["**/.*"], | |||
| server: "./server.ts", | |||
| serverConditions: ["worker"], | |||
There was a problem hiding this comment.
Same comment I left on the last one—IMHO this should be ["workerd", "worker", "browser"]
|
@pcattori Should we get these changes in the stacks as well? |
This was referenced Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #6229
Deno template is not changed as their is an existing bug with that template. Will fix and update Deno template as a follow-on.