Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid re-prefetching stylesheets for active routes during a revalidation #6679

Merged
merged 5 commits into from Jul 6, 2023
Merged

Avoid re-prefetching stylesheets for active routes during a revalidation #6679

merged 5 commits into from Jul 6, 2023

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Jun 23, 2023 •
edited

TODO

  • See if there's any way to short circuit any earlier in the flow? Might not be since links() could return new stuff
  • Tests

Closes #5448

@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2023 •
edited

🦋 Changeset detected

Latest commit: a989aba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/react Patch
@remix-run/testing Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 linked an issue Jun 23, 2023 that may be closed by this pull request
UseFetcher causes links to be loaded again #5448
Closed
1 task
jacob-ebey
jacob-ebey reviewed Jun 30, 2023
View reviewed changes
packages/remix-react/links.ts Outdated
(link) =>
(!link.media || window.matchMedia(link.media).matches) &&
document.querySelector(
`head link[rel="stylesheet"][href="${link.href}"]`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we care about the head specifically? If a user manually renders a link tag in the root component, but in the body for some reason, should that not also be deduped?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah - we can remove it in case they do any manual rendering of their own or the user puts <Links> into body for some reason

@brophdawg11 brophdawg11 marked this pull request as ready for review July 5, 2023 20:46
@brophdawg11 brophdawg11 merged commit eccc180 into dev Jul 6, 2023
9 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/stylesheet-re-prefetch branch July 6, 2023 15:28
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jul 6, 2023
@brophdawg11 brophdawg11 mentioned this pull request Jul 6, 2023
Closed
1 task
@brophdawg11 brophdawg11 self-assigned this Jul 6, 2023
@brophdawg11 brophdawg11 linked an issue Jul 6, 2023 that may be closed by this pull request
The resource […] was preloaded using link preload but not used #4257
Closed
@brophdawg11 brophdawg11 mentioned this pull request Jul 6, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-eccc180-20230707 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Jul 13, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Jul 19, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob-ebey jacob-ebey jacob-ebey approved these changes

Assignees

@brophdawg11 brophdawg11

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UseFetcher causes links to be loaded again The resource […] was preloaded using link preload but not used
2 participants
@brophdawg11 @jacob-ebey