Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server-runtime): support Priority Set-Cookie attribute #6770

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

haines
Copy link
Contributor

@haines haines commented Jul 5, 2023

This PR bumps the dependency on cookie to ^0.5.0 in order to gain support for the Priority Set-Cookie attribute.

cookie@0.5.0 also includes performance improvements and fixes the expires option to reject invalid dates (changelog).

Testing Strategy:

This test covers this code

@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2023

🦋 Changeset detected

Latest commit: 85c55ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/server-runtime Minor
@remix-run/cloudflare Minor
@remix-run/deno Minor
@remix-run/dev Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/architect Minor
@remix-run/express Minor
@remix-run/serve Minor
@remix-run/testing Minor
create-remix Minor
remix Minor
@remix-run/css-bundle Minor
@remix-run/eslint-config Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 5, 2023

Hi @haines,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 5, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brophdawg11 brophdawg11 added feat:cookies dependencies Pull requests that update a dependency file labels Jul 10, 2023
@MichaelDeBoey MichaelDeBoey added BREAKING CHANGE This change will require a major version bump package:server-runtime and removed BREAKING CHANGE This change will require a major version bump labels Jul 10, 2023
@haines
Copy link
Contributor Author

haines commented Aug 4, 2023

I've rebased this to resolve conflicts - could someone please approve the workflows again?

@haines
Copy link
Contributor Author

haines commented Sep 15, 2023

I've rebased this again to resolve conflicts - could someone please approve the workflows again?

Is there anything blocking this getting merged?

@haines haines force-pushed the update-cookie branch 2 times, most recently from 7fe37ed to b4cea55 Compare October 23, 2023 11:53
@haines
Copy link
Contributor Author

haines commented Oct 23, 2023

I've rebased this again to resolve conflicts - could someone please approve the workflows again?

Would love to get this merged please 🙏

@haines haines force-pushed the update-cookie branch 2 times, most recently from 8d2f4f8 to c88bfd0 Compare November 3, 2023 10:36
@haines
Copy link
Contributor Author

haines commented Nov 3, 2023

I've rebased again...

@MichaelDeBoey any chance of shipping this please?

Signed-off-by: Andrew Haines <andrew@haines.org.nz>
@brophdawg11 brophdawg11 merged commit e69dff6 into remix-run:dev Nov 6, 2023
5 checks passed
@haines haines deleted the update-cookie branch November 6, 2023 18:54
@haines
Copy link
Contributor Author

haines commented Nov 6, 2023

Thanks 🎉

@brophdawg11
Copy link
Contributor

Thank you!

Copy link
Contributor

🤖 Hello there,

We just published version 2.3.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.3.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants