Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-react): fix fetcher.formEncType #6807

Closed
wants to merge 17 commits into from
Closed

fix(remix-react): fix fetcher.formEncType #6807

wants to merge 17 commits into from

Conversation

AlemTuzlak
Copy link
Contributor

I believe that there is a typing issue with fetchers where the encType is not typed correctly, I noticed this when using useNavigate where the hook was typed but the fetcher wasn't so I tracked it down and fixed it.

Testing Strategy:

  • Import useFetcher or useFetchers
  • The type of formEncType should be FormEncType | undefined instead of string | undefined

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2023

⚠️ No Changeset found

Latest commit: 2ff1cfb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 10, 2023

Hi @AlemTuzlak,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 10, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brophdawg11
Copy link
Contributor

Thank you! Since this contains code changes, would you mind repointing to dev and adding a patch changeset via yarn changeset?

@AlemTuzlak
Copy link
Contributor Author

Thank you! Since this contains code changes, would you mind repointing to dev and adding a patch changeset via yarn changeset?

@brophdawg11 will do!

@MichaelDeBoey MichaelDeBoey changed the title Fixed fetcher formEncType type in remix apps fix(remix-react): fix fetcher.formEncType Jul 10, 2023
@MichaelDeBoey MichaelDeBoey added needs-response We need a response from the original author about this issue/PR renderer:react labels Jul 10, 2023
@AlemTuzlak AlemTuzlak changed the base branch from main to dev July 11, 2023 07:10
@AlemTuzlak
Copy link
Contributor Author

closing in favor of #6810

@AlemTuzlak AlemTuzlak closed this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed feat:routing feat:typescript needs-response We need a response from the original author about this issue/PR renderer:react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants