Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev): remove boolean option for polyfills #6877

Merged
merged 3 commits into from Jul 19, 2023

Conversation

markdalgleish
Copy link
Member

This PR makes a couple of notable changes:

  • Removes the boolean option for serverNodeBuiltinsPolyfill, ensuring that there's no serverNodeBuiltinsPolyfill: true in v2 so that we don't need to contie maintaining a canonical server polyfill config.
  • Reintroduces "empty" polyfills for fs/fs/promises and crypto modules, matching the earlier behaviour as of Remix v1.17.0 while still allowing consumers to override it.

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2023

🦋 Changeset detected

Latest commit: ae9fc81

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Minor
create-remix Minor
remix Minor
@remix-run/architect Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/css-bundle Minor
@remix-run/deno Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/netlify Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor
@remix-run/vercel Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 merged commit 84b2304 into release-next Jul 19, 2023
9 checks passed
@brophdawg11 brophdawg11 deleted the markdalgleish/remove-polyfills-boolean branch July 19, 2023 13:16
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0-pre.5 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants