Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-react): use unique key for script:ld+json meta descriptors #6954

Merged
merged 6 commits into from Aug 8, 2023

Conversation

wilcoschoneveld
Copy link
Contributor

Closes: #6953

  • Docs
  • Tests

Testing Strategy:

Not sure how to run automated tests for this, how to test if the components have unique keys

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2023

🦋 Changeset detected

Latest commit: ca0d6d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/react Patch
@remix-run/testing Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wilcoschoneveld wilcoschoneveld changed the base branch from main to dev July 25, 2023 14:57
@brophdawg11
Copy link
Contributor

Thanks for the PR @wilcoschoneveld! Would you mind adding your github username to contributors.yml to agree to and sign the CLA and we can get this merged?

https://github.com/remix-run/remix/blob/main/docs/pages/contributing.md#contributor-license-agreement

@brophdawg11 brophdawg11 self-assigned this Aug 7, 2023
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 7, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@wilcoschoneveld
Copy link
Contributor Author

@brophdawg11 done!

@brophdawg11 brophdawg11 merged commit 23f27ef into remix-run:dev Aug 8, 2023
9 checks passed
@brophdawg11
Copy link
Contributor

Thanks @wilcoschoneveld!

@wilcoschoneveld
Copy link
Contributor Author

@brophdawg11 thanks for merging!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-a179aa7-20230809 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-b1149bb-20230810 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V2_MetaFunction using script:ld+json twice results in same key warning
2 participants