Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): improve minified CSS compatibility #7187

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

markdalgleish
Copy link
Member

Fixes #6114

As the changeset says, we now minify CSS targeting the Remix browser support baseline (i.e. anything that supports ES module scripts), whereas previously CSS was minified using esbuild's default "esnext" target. This meant that CSS in the production build could be using properties that are unsupported in some browsers.

This change also means you now have more control over CSS transformations using the built-in PostCSS support since they won't be reversed by esbuild's minification.

@markdalgleish markdalgleish added package:dev v2 Issues related to v2 apis labels Aug 16, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2023

🦋 Changeset detected

Latest commit: d629768

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish changed the title feat(dev): improve minified CSS compatibility fix(dev): improve minified CSS compatibility Aug 16, 2023
@markdalgleish markdalgleish self-assigned this Aug 17, 2023
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@markdalgleish markdalgleish merged commit 63a55e0 into dev Aug 18, 2023
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/improve-css-min-compat branch August 18, 2023 23:32
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Aug 18, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-3447963-20230819 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed package:dev v2 Issues related to v2 apis
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

None yet

3 participants