Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: small updates #7191

Merged
merged 5 commits into from
Sep 19, 2023
Merged

docs: small updates #7191

merged 5 commits into from
Sep 19, 2023

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Aug 17, 2023 •
edited
Loading

Follow-up of @ryanflorence's docs changes

Closes #7441

@MichaelDeBoey MichaelDeBoey added docs v2 Issues related to v2 apis labels Aug 17, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: da2a78d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey force-pushed the small-docs-changes branch 2 times, most recently from 4712c81 to f500f3d Compare August 21, 2023 16:51
@brophdawg11 brophdawg11 removed their request for review August 22, 2023 15:12
@MichaelDeBoey MichaelDeBoey force-pushed the small-docs-changes branch 15 times, most recently from e74c7da to efb25a0 Compare August 25, 2023 20:51
@MichaelDeBoey MichaelDeBoey mentioned this pull request Aug 25, 2023
Closed
This was referenced Sep 16, 2023
Closed
Closed
This was referenced Sep 16, 2023
Closed
Closed
@MichaelDeBoey MichaelDeBoey force-pushed the small-docs-changes branch 2 times, most recently from f9b4c10 to fd01922 Compare September 16, 2023 15:49
@MichaelDeBoey MichaelDeBoey mentioned this pull request Sep 16, 2023
Closed
This was referenced Sep 17, 2023
Closed
Closed
Closed
@brophdawg11
Copy link
Contributor

Left a few minor comments - let's get those addressed and merge this. It's a bit too big to really give it a close look so let's merge it and then if anything surfaces from the community we can adjust as needed. We may want to keep these docs updates a bit smaller in the future so they're easier to review :)

@MichaelDeBoey MichaelDeBoey force-pushed the small-docs-changes branch 2 times, most recently from a2429ca to 7962e4d Compare September 18, 2023 19:27
@jvzaniolo jvzaniolo mentioned this pull request Sep 19, 2023
Closed
@brophdawg11 brophdawg11 merged commit c0794d9 into remix-run:main Sep 19, 2023
9 checks passed
@MichaelDeBoey MichaelDeBoey deleted the small-docs-changes branch September 19, 2023 16:20
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machour machour Awaiting requested review from machour

@markdalgleish markdalgleish Awaiting requested review from markdalgleish

@ryanflorence ryanflorence Awaiting requested review from ryanflorence

@brophdawg11 brophdawg11 Awaiting requested review from brophdawg11

Assignees
No one assigned
Labels
CLA Signed docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: missing keywords and variables in discussion topics
3 participants
@MichaelDeBoey @brophdawg11 @ryanflorence