Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): kill app server when remix dev terminates #7280

Merged
merged 1 commit into from
Aug 29, 2023
Merged

fix(dev): kill app server when remix dev terminates #7280

merged 1 commit into from
Aug 29, 2023

Conversation

pcattori
Copy link
Contributor

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 8279059

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori
Copy link
Contributor Author

holding off on merging this. need to rebase to release-next after v2 prerelease is cut

@pcattori pcattori marked this pull request as draft August 28, 2023 20:26
@pcattori pcattori changed the base branch from dev to release-next August 29, 2023 02:04
@pcattori pcattori force-pushed the pedro/ctrl-c-kill-app branch 2 times, most recently from 2077d4f to ee1443e Compare August 29, 2023 16:00
@pcattori pcattori marked this pull request as ready for review August 29, 2023 16:01
@pcattori pcattori merged commit 86a92aa into release-next Aug 29, 2023
9 checks passed
@pcattori pcattori deleted the pedro/ctrl-c-kill-app branch August 29, 2023 16:38
@github-actions github-actions bot mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngbrown ngbrown ngbrown left review comments

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees
No one assigned
Labels
CLA Signed package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pcattori @ngbrown @MichaelDeBoey