Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use active matches in meta/links during SPA mode SSR/hydration #8538

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

brophdawg11
Copy link
Contributor

We do this for Scripts but not for Meta/Links so if you have meta/links in your index.html they incorrectly get SSR'd into the index.html file - causing a hydration issue since we only hydrate the root route.

  • fa9e138 can be ignored - it was a test reorg before adding the failing test
  • 0abe524 has all of the functional changes

Closes #8536

Copy link

changeset-bot bot commented Jan 17, 2024

🦋 Changeset detected

Latest commit: a57838e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/react Patch
@remix-run/testing Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 linked an issue Jan 17, 2024 that may be closed by this pull request
@brophdawg11 brophdawg11 merged commit a6783b7 into release-next Jan 17, 2024
5 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/spa-mode-meta branch January 17, 2024 17:06
Copy link
Contributor

🤖 Hello there,

We just published version 2.5.1-pre.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.5.1-pre.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.5.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fouc in SPA mode with tailwindcss in production mode
2 participants