Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vite: fix "could not fast refresh" false alarm #8580

Merged
merged 1 commit into from
Jan 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/fast-dodos-yell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@remix-run/dev": patch
---

Vite: fix "could not fast refresh" false alarm

HMR is already functioning correctly but was incorrectly logging that it "could not fast refresh" on internal client routes.
Now internal client routes correctly register Remix exports like `meta` for fast refresh,
which removes the false alarm.
3 changes: 2 additions & 1 deletion packages/remix-dev/vite/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1468,7 +1468,8 @@ function addRefreshWrapper(
code: string,
id: string
): string {
let isRoute = getRoute(pluginConfig, id);
let isRoute =
id.endsWith(CLIENT_ROUTE_QUERY_STRING) || getRoute(pluginConfig, id);
let acceptExports = isRoute
? [
"clientAction",
Expand Down