Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors with Vite .css?url imports #8829

Merged
merged 1 commit into from Feb 21, 2024

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Feb 21, 2024

Fixes #8813

The linked issue was introduced in #8796 but slipped through because the Vite CSS test didn't assert the build command succeeded without any output to stderr. The test still managed to pass because the build output still worked if you ignored the error message which meant all of our assertions still passed. I've updated the test to catch this issue along with the fix.

Copy link

changeset-bot bot commented Feb 21, 2024

🦋 Changeset detected

Latest commit: b036cdd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

...ssrCssUrlFilePaths,
...ssrChunkAssetPaths,
]);
let clientAssetPaths = getViteManifestAssetPaths(clientViteManifest);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the root of the issue. The logic for extracting assets from the client and server builds differed. These need to be the same because we compare their assets to detect any server-only assets that need to be moved to the client build directory (e.g. .css?url imports that are only ever used in a loader, so they don't get included in the client build). The linked issue was because we were attempting to move a file to a path that already existed.

@markdalgleish markdalgleish changed the title Vite: Fix build errors with .css?url imports Fix build errors with Vite .css?url imports Feb 21, 2024
@markdalgleish markdalgleish merged commit e775fd0 into dev Feb 21, 2024
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/fix-css-url-imports branch February 21, 2024 06:57
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Feb 21, 2024
Copy link
Contributor

🤖 Hello there,

We just published version 2.7.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant