Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: simplify template entry.server files #8909

Merged
merged 4 commits into from
Feb 27, 2024
Merged

chore: simplify template entry.server files #8909

merged 4 commits into from
Feb 27, 2024

Conversation

jacob-ebey
Copy link
Member

@jacob-ebey jacob-ebey commented Feb 27, 2024 •
edited

  • properly handle errors in Cloudflare template
  • drastically simplify node templates

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2024 •
edited

⚠️ No Changeset found

Latest commit: 1c265b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jacob-ebey jacob-ebey merged commit d7c9ea5 into main Feb 27, 2024
9 checks passed
@jacob-ebey jacob-ebey deleted the simplify_entry_server branch February 27, 2024 22:18
jacob-ebey added a commit that referenced this pull request Feb 27, 2024
@jacob-ebey
Revert "chore: simplify template entry.server files (#8909)"
efa648b 
This reverts commit d7c9ea5.
@jacob-ebey jacob-ebey mentioned this pull request Feb 27, 2024
Merged
@jacob-ebey jacob-ebey restored the simplify_entry_server branch February 27, 2024 22:23
IgnusG pushed a commit to IgnusG/remix that referenced this pull request Mar 4, 2024
@jacob-ebey @IgnusG
chore: simplify template entry.server files (remix-run#8909)
4c96849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brookslybrand brookslybrand brookslybrand approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacob-ebey @brookslybrand