-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tailwind CSS to the templates #9585
Conversation
brookslybrand
commented
Jun 7, 2024
•
edited
Loading
edited
- Add tailwind
- Test all the templates
|
Worth noting that Tailwind v4 is planning to release with a Vite plugin that should obsolete all/most of this setup. Might be worth waiting for that, but not sure when they plan to ship it |
Also, by doing this we lose the benefit that Setting up Tailwind will always take up to a few minutes, compared to months or years of building the project. How often are we starting new projects that those minutes became so unbearable? Even though I love Tailwind, I feel like this would be a step backwards, and a maintenance burden for you. |
Haha yeah, I thought about that. If it's a matter of weeks I'm happy to wait, but I have no idea how long it'll be (or if anyone knows) |
I appreciate the thoughts. it's hard balance. The majority of times people run something like
It's a pretty small amount of the time people run a create-* CLI to actually start a project they'll be working on for months or years. So I kind of few it the opposite, how many minutes are added for projects that are going to last months or years to either delete tailwind or modify the way they want to (even using I definitely get why it can be seen as a step backwards, since it somewhat degrades the "purity" of the Remix template. I'm not sure I understand why you think it'll be a maintenance burden? Especially once tailwind 4 with the Vite plugin comes out |
The other piece I should mention is that we want to make the templates a little nicer and more styled, so either we'll have to use something like tailwind, or ship a bunch of custom css or css modules that the user will delete. So either way in an attempt to make the templates more inviting, we're going to be including some degree of "you have to delete this stuff". I'm not sure the best way to strike that balance |
Ok, I'm convinced. I would rather provide that than the way Vite starts. Forget what I said about maintainenance burden, I was mostly refering to the purity, as you recognized. |
Yes, when I create an example on StackBlitz or Codesandbox, it's always a hassle if you want to use something like |
Thanks for your thoughts! We're gonna be updating these templates a bit over the next week or two I imagine, so please reach out if you feel like anything is funky Thanks @kiliman for the thoughts as well |