switch to charset_normalizer for encoding to support py 3.10+ #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brockhaywood
commented
Aug 8, 2022
| @@ -55,7 +55,7 @@ def test_empty_df(): | |||
| [ | |||
| (b"abcde", "utf-8"), # straight up ascii is a subset of unicode | |||
| (b"Eyjafjallaj\xc3\xb6kull", "utf-8"), # actual unicode | |||
| (b"\xC4pple", "WINDOWS-1252"), # non-unicode, ISO characterset | |||
| (b"\xC4pple", "cp037"), # non-unicode, ISO characterset | |||
There was a problem hiding this comment.
It seems there is some disagreement between the latest versions of the libs on py3.10 as to what this should be.
cchardet: WINDOWS-1252
chardet: ISO-8859-1
charset_normalizer: cp037
|
Looks like travis no longer exists.. and tox has been removed a6741e0 so im not sure what the compatibility of this is like. With that said, tests pass on 3.7.4. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches partridge to use charset_normalizer instead of cchardet.
Due to this issue: #73
Potential alternative fix: #75