Await exposeFunction (#4)

Examples such as at https://github.com/puppeteer/puppeteer/blob/d6a88a9768ddc2bf410f3171fcd63fa304d7d0be/docs/api/puppeteer.page.exposefunction.md show to do this and it seems to help make things better.
remix · Oct 4, 2022 · eeb3301 · eeb3301
1 parent 20c5e69
commit eeb3301
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/storycap/package.json b/packages/storycap/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@remix/storycap",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "A Storybook addon, Save the screenshot image of your stories! via puppeteer.",
   "main": "lib/index.js",
   "typings": "lib/index.d.ts",

diff --git a/packages/storycap/src/node/capturing-browser.ts b/packages/storycap/src/node/capturing-browser.ts
@@ -107,7 +107,9 @@ export class CapturingBrowser extends StoryPreviewBrowser {
       waitBrowserMetricsStable: () => this.waitBrowserMetricsStable('preEmit'),
       setViewport: (viewport: Viewport) => this.page.setViewport(viewport),
     };
-    Object.entries(exposed).forEach(([k, f]) => this.page.exposeFunction(k, f));
+    for (const [k, f] of Object.entries(exposed)) {
+      await this.page.exposeFunction(k, f);
+    }
   }
 
   private async reload() {