Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'skipIfPublished' argument to CLI and API #38

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

daviwil
Copy link
Contributor

@daviwil daviwil commented Jun 7, 2018

This change adds a new skipIfPublished argument to the CLI and API to
indicate that a new release should not be created if a non-draft release
with the same tag already exists.

Fixes #37.

This change adds a new `skipIfPublished` argument to the CLI and API to
indicate that a new release should not be created if a non-draft release
with the same tag already exists.

Fixes remixz#37.
@daviwil
Copy link
Contributor Author

daviwil commented Jun 7, 2018

Happy to change back the variable that I renamed, but the logic seems easier to understand with the new name.

@marceloavf
Copy link
Collaborator

Excellent, seems to be everything fine, I'll do a test early this morning and merge it as soon as possible.
And the new variable is more readable and easier to understand.

Thank you so much!

@marceloavf marceloavf merged commit a01b25d into remixz:master Jun 8, 2018
@marceloavf
Copy link
Collaborator

🎉 This PR is included in version 1.6.0 🎉

Thank you!

@daviwil
Copy link
Contributor Author

daviwil commented Jun 8, 2018

Awesome, thanks so much for accepting the change and pushing a release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants