Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling dark mode blocks interaction with the rest of the page #7

Open
hawkins opened this issue Dec 17, 2017 · 0 comments
Open

Enabling dark mode blocks interaction with the rest of the page #7

hawkins opened this issue Dec 17, 2017 · 0 comments

Comments

@hawkins
Copy link

hawkins commented Dec 17, 2017

I'm sure you know this already, but turning on dark-mode effectively puts an overlay above the rest of the page's interactive components (such as the next episode). This means you have to turn off dark mode to go to the next episode or a different series.

Have you thought about other ways to do this, i.e., changing CSS colors instead of just drawing an overlay? In other words, add a class to the root element and all elements below it with background colors or font colors will have a separate color defined for when they're below an element with the .dark-mode class. (Basically, see this pen https://codepen.io/HarlemSquirrel/pen/NdMebZ)

@hawkins hawkins mentioned this issue Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant