Update 1848 fix to not break testIssue1027RepeatingPositionalParamsWi…

…thMinMultiplicity
remkop · May 28, 2023 · 9add2af · 9add2af
1 parent 4b41a21
commit 9add2af
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/main/java/picocli/CommandLine.java b/src/main/java/picocli/CommandLine.java
@@ -13025,13 +13025,16 @@ void validate(CommandLine commandLine) {
             }
 
             private boolean containsRequiredOptionsOrSubgroups(ArgGroupSpec argGroupSpec) {
-                return containsRequiredOptions(argGroupSpec) || containsRequiredSubgroups(argGroupSpec);
+                return containsRequiredOptionsOrParameters(argGroupSpec) || containsRequiredSubgroups(argGroupSpec);
             }
 
-            private boolean containsRequiredOptions(ArgGroupSpec argGroupSpec) {
+            private boolean containsRequiredOptionsOrParameters(ArgGroupSpec argGroupSpec) {
                 for ( OptionSpec option : argGroupSpec.options() ) {
                     if ( option.required() ) { return true; }
                 }
+                for ( PositionalParamSpec param : argGroupSpec.positionalParameters() ){
+                    if( param.required() ){return true;}
+                }
                 return false;
             }
 
@@ -13043,7 +13046,7 @@ private boolean containsRequiredSubgroups(ArgGroupSpec argGroupSpec) {
                         for ( ArgGroupSpec subsubgroup : subgroup.subgroups() ) {
                             result &= containsRequiredOptionsOrSubgroups(subsubgroup);
                         }
-                        return result && containsRequiredOptions(subgroup);
+                        return result && containsRequiredOptionsOrParameters(subgroup);
                     } else {
                         return containsRequiredOptionsOrSubgroups(subgroup);
                     }