Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to JLine3 3.16.0 #1175

Closed
rnc opened this issue Sep 16, 2020 · 3 comments · Fixed by #1176
Closed

Update to JLine3 3.16.0 #1175

rnc opened this issue Sep 16, 2020 · 3 comments · Fixed by #1176
Labels
type: enhancement ✨
Milestone
4.5.2

Comments

@rnc
Copy link
Contributor

rnc commented Sep 16, 2020

I was having problems configuring a widget in my App which I had configured according to the picocli example. After some discussions on jline/jline3#571 it would seem that if picocli updated to 3.16.0 then this would resolve it.
Thanks!
@remkop remkop added this to the 4.6 milestone Sep 17, 2020
@rnc rnc mentioned this issue Sep 17, 2020
Merged
remkop added a commit that referenced this issue Sep 17, 2020
@remkop
[#1175] DOC add section on compatible versions to the picocli-shell-j…
f75d892 
…line3 README
remkop added a commit that referenced this issue Sep 17, 2020
@remkop
[#1175] partial prepare for bumping JLine version to 3.16.0: fix comp…
39a8940 
…iler errors

* remove @OverRide for methods execute and commandDescription(String), which were removed from the org.jline.console.CommandRegistry interface
@remkop
Copy link
Owner

remkop commented Sep 17, 2020

I started to migrate to JLine 3.16, but it must have some backwards-incompatible changes, because the Example in picocli-shell-jline3/src/test no longer compiles...
This example is also shown in the README so we should update it to the new JLine 3.16 API.

I went ahead added a section to the README on compatible versions; I think it is important to start tracking this.

@mattirn, could I ask you to help migrating the Example to the new JLine 3.16 API?

@rnc
Copy link
Contributor Author

rnc commented Sep 17, 2020 •
edited

@remkop I've got it compiling and working - although I haven't updated the docs - I'll send a PR for what I have.

There is porting information for moving to 3.16.0 in jline/jline3#551

@rnc rnc mentioned this issue Sep 17, 2020
Merged
@remkop
Copy link
Owner

remkop commented Sep 17, 2020

Great, thank you! I will update the docs in a bit.
Many thanks for the PR!

@remkop remkop linked a pull request Sep 17, 2020 that will close this issue
ISSUE1175 : Update JLine to 3.16.0 #1176
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement ✨
Projects
None yet
Milestone
4.5.2
Development

Successfully merging a pull request may close this issue.

ISSUE1175 : Update JLine to 3.16.0 rnc/picocli
2 participants
@rnc @remkop