Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate auto-complete for hidden attributes in picocli.shell.jline3.PicoCommand #2074

Closed
clebertsuconic opened this issue Jul 28, 2023 · 1 comment · Fixed by #2075
Closed

Don't generate auto-complete for hidden attributes in picocli.shell.jline3.PicoCommand #2074

clebertsuconic opened this issue Jul 28, 2023 · 1 comment · Fixed by #2075
Labels
theme: auto-completion An issue or change related to auto-completion theme: integration An issue or change related to integration with other frameworks, shells or operating systems theme: shell An issue or change related to interactive (JLine) applications type: bug 🐛
Milestone
4.7.5

Comments

@clebertsuconic
Copy link
Contributor

#1076 was about hidden commands on the auto-complete.

However the JLine3 integration still showing hidden attributes.

Can you bring the same fix into JLine3? I don't see any use or mention of hidden from jline3.PicoCommand.

I'm implementing pico / line into ActiveMQ Artemis, and a few attributes that I'm hiding are showing on the JLine terminal but they are being ignored (as expected) on the bash auto-complete generation.
@clebertsuconic
Copy link
Contributor Author

I have sent a Pull Request for this: #2075

clebertsuconic added a commit to clebertsuconic/picocli that referenced this issue Jul 28, 2023
@clebertsuconic
Issue remkop#2074 AutoComplete with jline3 is showing hidden values
9a53050
remkop pushed a commit that referenced this issue Jul 30, 2023
@clebertsuconic @remkop
Issue #2074 AutoComplete with jline3 is showing hidden values
460496b
@remkop remkop linked a pull request Jul 30, 2023 that will close this issue
Issue #2074 AutoComplete with jline3 is showing hidden values #2075
Merged
@remkop remkop added this to the 4.7.5 milestone Jul 30, 2023
@remkop remkop added type: bug 🐛 theme: auto-completion An issue or change related to auto-completion theme: shell An issue or change related to interactive (JLine) applications theme: integration An issue or change related to integration with other frameworks, shells or operating systems labels Jul 30, 2023
remkop added a commit that referenced this issue Jul 30, 2023
@remkop
[#2074][#2075] update RELEASE-NOTES
a13408a
@remkop remkop closed this as completed Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme: auto-completion An issue or change related to auto-completion theme: integration An issue or change related to integration with other frameworks, shells or operating systems theme: shell An issue or change related to interactive (JLine) applications type: bug 🐛
Projects
None yet
Milestone
4.7.5
Development

Successfully merging a pull request may close this issue.

Issue #2074 AutoComplete with jline3 is showing hidden values clebertsuconic/picocli
2 participants
@clebertsuconic @remkop