Completion scripts have redundant case statement

[dwalluck]

I believe that we can simplify the competition scripts by using one case statement instead of two without losing any functionality. Replace:

case ${CURR_WORD} in
    foo)
      COMPREPLY=( $( compgen -- "" ) )
      return $?
      ;;
     *)
      case ${PREV_WORD} in
        foo)
          COMPREPLY=( $( compgen  -- "${CURR_WORD}" ) )
          ;;
    esac
esac

with

case ${PREV_WORD} in
    foo)
      COMPREPLY=( $( compgen -- "${CURR_WORD}" ) )
      return $?
      ;;
esac

[dwalluck]

This also seems to make competition of short options with an argument not complete correctly, although the long option version work.

[remkop]

I am a bit worried about regressions, so I want to test this one extra carefully but otherwise no objections.

[dwalluck]

It will fix the option argument handling, which I believe was a pre-existing bug. I have a pull request ready, but it's on top of #469.

[dwalluck]

I didn't see any regressions, but the following behavior is improved:

ARG_OPTS="-f --foo"
FOO_OPTION_ARGS="bar baz"

Then, --foo<TAB><TAB> always worked (and showed the options and allowed completing them), but -f<TAB><TAB> was showing bar baz but not complementing them (as a space is not being added after -f to trigger the competition).

[remkop]

Confirmed and merged. Nice work!