New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleanup and minor fixes #1040
Conversation
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall some good catches, but there are some places where I like the current style.
Specifically:
- I generally think String concatenation with
+
gives more readable code thanStringBuilder.append
- Using
Map.Entry
to loop over maps is more efficient, but tends to give longer and less readable code.
Codecov Report
@@ Coverage Diff @@
## master #1040 +/- ##
============================================
- Coverage 94.37% 94.35% -0.02%
Complexity 443 443
============================================
Files 2 2
Lines 6474 6469 -5
Branches 1728 1726 -2
============================================
- Hits 6110 6104 -6
- Misses 96 98 +2
+ Partials 268 267 -1
Continue to review full report at Codecov.
|
Reverted those changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Merged into master. |
Removed duplicated null checking, fix several potential NullPointerException.
Also fixed NPE when user Ctrl+D in password prompt.