Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: fix sample code in chapter "Validation" #1155

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Documentation: fix sample code in chapter "Validation" #1155

merged 1 commit into from
Aug 26, 2020

Conversation

deining
Copy link
Contributor

@deining deining commented Aug 26, 2020

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2020

Codecov Report

Merging #1155 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1155      +/-   ##
============================================
+ Coverage     94.25%   94.30%   +0.04%     
  Complexity      455      455              
============================================
  Files             2        2              
  Lines          6667     6667              
  Branches       1791     1792       +1     
============================================
+ Hits           6284     6287       +3     
+ Misses          105      102       -3     
  Partials        278      278              
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/CommandLine.java 94.14% <0.00%> (+0.04%) 314.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecba9b8...1f72f6c. Read the comment docs.

@remkop
Copy link
Owner

remkop commented Aug 26, 2020

Thanks for the review and the fixes!
I should obviously run the sample code before putting it in the docs! 😳

Merged and published.
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants