Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1156, make HelpCommand respect subcommands case-sensitivity and abbreviation #1172

Merged
merged 10 commits into from
Sep 12, 2020
Merged

Fix #1156, make HelpCommand respect subcommands case-sensitivity and abbreviation #1172

merged 10 commits into from
Sep 12, 2020

Conversation

NewbieOrange
Copy link
Contributor

@NewbieOrange NewbieOrange commented Sep 11, 2020 •
edited

This pull request will fix #1156.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2020 •
edited

Codecov Report

Merging #1172 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1172      +/-   ##
============================================
+ Coverage     94.29%   94.30%   +0.01%     
  Complexity      455      455              
============================================
  Files             2        2              
  Lines          6661     6673      +12     
  Branches       1792     1793       +1     
============================================
+ Hits           6281     6293      +12     
  Misses          102      102              
  Partials        278      278
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/CommandLine.java 94.14% <100.00%> (+0.01%) 314.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af6f290...ab663aa. Read the comment docs.

@NewbieOrange NewbieOrange mentioned this pull request Sep 11, 2020
Closed
@NewbieOrange NewbieOrange changed the title Fix #1156, make HelpCommand respect subcommands case-sensitivity Fix #1156, make HelpCommand respect subcommands case-sensitivity and abbreviation Sep 11, 2020
remkop
remkop requested changes Sep 12, 2020
View reviewed changes
Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, many thanks!
I think we are almost there.

src/main/java/picocli/CommandLine.java Show resolved Hide resolved
src/main/java/picocli/CommandLine.java Show resolved Hide resolved
src/main/java/picocli/CommandLine.java Show resolved Hide resolved
@remkop remkop merged commit dbae868 into remkop:master Sep 12, 2020
@remkop
Copy link
Owner

remkop commented Sep 12, 2020

Merged.

@NewbieOrange Thank you very much for the PR and for your patience during the reviews!
Your contributions are much appreciated!

@NewbieOrange NewbieOrange deleted the fix-#1156 branch September 13, 2020 01:48
remkop added a commit that referenced this pull request Sep 13, 2020
@remkop
[#1156][#1172] update RELEASE-NOTES.md for built-in Help fix
e11712b
@remkop remkop added this to the 4.6 milestone Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remkop remkop Awaiting requested review from remkop

Assignees
No one assigned
Labels
type: bug 🐛
Projects
None yet
Milestone
4.5.2
Development

Successfully merging this pull request may close these issues.

Built-in Help being used on subcommands, still case-sensitive even if case-sensitivity disabled
3 participants
@NewbieOrange @codecov-commenter @remkop