Use .invalid domain name for InetAddress test #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some DNS setups such as ISP "DNS hijacking" will return an IP address for garbage names. Using the ".invalid" domain specified in RFC 6761 makes the test more reliable.
Codecov Report
@@ Coverage Diff @@
## master #1179 +/- ##
=========================================
Coverage 94.30% 94.30%
Complexity 455 455
=========================================
Files 2 2
Lines 6673 6673
Branches 1793 1793
=========================================
Hits 6293 6293
Misses 102 102
Partials 278 278 Continue to review full report at Codecov.
|
|
Merged. Nice! I was not aware of RFC 6761, very good to know! Thanks for the contribution! |
remkop
added a commit
that referenced
this pull request
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some DNS setups such as ISP "DNS hijacking" will return an IP address for garbage names. Using the ".invalid" domain specified in RFC 6761 makes the test more reliable.